Changeset 40200c in indico

Timestamp:

04/20/11 10:43:48 (2 years ago)

Author:

Jose Benito <jose.benito.gonzalez@…>

Branches:

master, hello-world-walkthrough, ipv6, v0.98-series, v0.98.2, v0.98.3, v0.98b2, v0.99, 051b2622c51afb171a1dedb46a0df4fbb0cbd02e, 0da0c1403bae8e51d8229f460181c71b9e6dda72

Children:

a43543

Parents:

26e470

git-author:

gcerto <giuseppe.certo@…> (03/03/11 10:06:16)

git-committer:

Jose Benito <jose.benito.gonzalez@…> (04/20/11 10:43:48)

Message:

[FIX] Popup Menu Defect

• A new PopupMenu? object was created everytime
• fixes #679

File:

• indico/MaKaC/webinterface/tpls/Header.tpl (modified) (6 diffs)

indico/MaKaC/webinterface/tpls/Header.tpl

@@ -63 +63 @@
 <script type="text/javascript">
 var createEventMenu = $E('createEventMenu');
+var eventPopupMenu;
 createEventMenu.observeClick(function(e) {
     var menuItems = {};
@@ -69 +70 @@
     menuItems['${ _("Create conference") }'] = "${ urlConference }";
 
+    //Create a new PopupMenu only if it has never been created before -> fix #679
+    if(!eventPopupMenu){
+        eventPopupMenu = new PopupMenu(menuItems, [createEventMenu], "globalMenuPopupList");
+    }
+
+    var pos = createEventMenu.getAbsolutePosition();
+    eventPopupMenu.open(pos.x, pos.y + 30);
+
     var infoItems = {}; //List used to print additional help on the menu (MUST use the same keys as menuItems)
     infoItems['${ _("Create lecture") }'] = "${ _("A <strong>lecture</strong> is a simple event to annouce a talk.<br/><strong>Features</strong>: poster creation, participants management,...") }";
     infoItems['${ _("Create meeting") }'] = "${ _("A <strong>meeting</strong> is an event that defines an agenda with many talks.<br/><strong>Features</strong>: timetable, minutes, poster creation, participants management,...") }";
     infoItems['${ _("Create conference") }'] = "${ _("A <strong>conference</strong> is a complex event with features to manage the whole life cycle of a conference.<br/><strong>Features</strong>: call for abstracts, registration, e-payment, timetable, badges creation, paper reviewing,...") }";
-
-    var menu = new PopupMenu(menuItems, [createEventMenu], "globalMenuPopupList");
-    var pos = createEventMenu.getAbsolutePosition();
-    menu.open(pos.x, pos.y + 30);
-
-    //Write down the content of the infoBubble
-    menu.drawInfoBubbles(infoItems);
+    eventPopupMenu.drawInfoBubbles(infoItems);
 
     return false;
@@ -87 +90 @@
 
     var administrationMenu = $E('administrationMenu');
+    var administrationPopupMenu;
     administrationMenu.observeClick(function(e) {
         var menuItems = {};
@@ -93 +97 @@
         menuItems["${ item['text']}"] = "${ item['url'] }"
         % endfor
-        var menu = new PopupMenu(menuItems, [administrationMenu], "globalMenuPopupList");
+        //Create a new PopupMenu only if it has never been created before -> fix #679
+        if(!administrationPopupMenu){
+            administrationPopupMenu = new PopupMenu(menuItems, [administrationMenu], "globalMenuPopupList");
+        }
         var pos = administrationMenu.getAbsolutePosition();
-        menu.open(pos.x, pos.y + 30);
+        administrationPopupMenu.open(pos.x, pos.y + 30);
         return false;
     });
@@ -102 +109 @@
 
 var helpMenu = $E('helpMenu');
+var helpPopupMenu;
 helpMenu.observeClick(function(e) {
     var menuItems = {};
@@ -109 +117 @@
     menuItems['${ _("Contact") }'] = "${ urlHandlers.UHContact.getURL() }";
 
-    var menu = new PopupMenu(menuItems, [helpMenu], "globalMenuPopupList");
+    //Create a new PopupMenu only if it has never been created before-> fix #679
+    if(!helpPopupMenu){
+        helpPopupMenu = new PopupMenu(menuItems, [helpMenu], "globalMenuPopupList");
+    }
     var pos = helpMenu.getAbsolutePosition();
-    menu.open(pos.x, pos.y + 30);
+    helpPopupMenu.open(pos.x, pos.y + 30);
     return false;
 });