Changeset 4bbdbe in indico for indico/MaKaC/webinterface/tpls/ShowExistingReviewingMaterial.tpl

Timestamp:

03/02/11 14:03:39 (2 years ago)

Author:

Jose Benito <jose.benito.gonzalez@…>

Branches:

master, burotel, hello-world-walkthrough, ipv6, v0.98-series, v0.98.2, v0.98.3, v0.98b1, v0.98b2, v0.99, b8c30da8ebdbdcbd675a873997cc3e95f567de49, 4287315ec967a3da168d83963c14001db8487d53

Children:

a3574e

Parents:

c3cd24

git-author:

Alexis Castilla Hernandez <alexis.castilla.hernandez@…> (03/02/11 10:10:57)

git-committer:

Jose Benito <jose.benito.gonzalez@…> (03/02/11 14:03:39)

Message:

[IMP] Code impromevents in AR and PR

• Changed set and get names in methods which are not getters or setters
• Changed numbers by constant names in type of paper reviewing
• Removed not necessary try except in get methods
• Included parameter manager in abstract reviewing services
• Removed the 'for..' to fossilize in abstractReviewing.py and reviewing.py
• Removed HTML code from notification templates python file to .tpl files and fixed a bug with 'from' var
• Added _() to tabs names
• New classes base for inheritance in PropToAcc? and PropToRej? (both, track manager and conference manager)
• Moved code to AbstractReviewing?.js and changed to OO
• Changed the python loop by js loop in PropToAcc/PropToRej? files

File:

• indico/MaKaC/webinterface/tpls/ShowExistingReviewingMaterial.tpl (modified) (4 diffs)

indico/MaKaC/webinterface/tpls/ShowExistingReviewingMaterial.tpl

@@ -1 +1 @@
 <% import MaKaC.webinterface.urlHandlers as urlHandlers %>
 <% from MaKaC.webinterface.rh.conferenceBase import RHSubmitMaterialBase %>
+<% from MaKaC.reviewing import ConferencePaperReview as CPR %>
+
 <div id="showStep1" class="groupTitleSmallPaper"><span><%= _("Step 1 - Upload paper") %></span></div>
 <%= existingMaterialsTitle %>
@@ -36 +38 @@
     var uploadAction = Indico.Urls.UploadAction.contribution;
     var visibility = '';
-     <% if  self._target.getConference().getConfPaperReview().getChoice() == 3: %>
+     <% if  self._target.getConference().getConfPaperReview().getChoice() == CPR.LAYOUT_REVIEWING: %>
         <% if not self._target.getReviewManager().getLastReview().isAuthorSubmitted() and not self._target.getReviewManager().getLastReview().getEditorJudgement().isSubmitted():%>
             <% if showSendButton: %>
@@ -49 +51 @@
         <% end %>
     <% end %>
-    <% if self._target.getConference().getConfPaperReview().getChoice() == 2: %>
+    <% if self._target.getConference().getConfPaperReview().getChoice() == CPR.CONTENT_REVIEWING: %>
         <% if not self._target.getReviewManager().getLastReview().isAuthorSubmitted() and not (self._target.getReviewManager().getLastReview().getRefereeJudgement().isSubmitted() or self._target.getReviewManager().getLastReview().anyReviewerHasGivenAdvice()): %>
             <% if showSendButton: %>
@@ -62 +64 @@
         <% end %>
     <% end %>
-    <% if  self._target.getConference().getConfPaperReview().getChoice() == 4: %>
+    <% if  self._target.getConference().getConfPaperReview().getChoice() == CPR.CONTENT_AND_LAYOUT_REVIEWING: %>
         <% if not self._target.getReviewManager().getLastReview().isAuthorSubmitted() and not (self._target.getReviewManager().getLastReview().getRefereeJudgement().isSubmitted() or self._target.getReviewManager().getLastReview().anyReviewerHasGivenAdvice() or self._target.getReviewManager().getLastReview().getEditorJudgement().isSubmitted()): %>
             <% if showSendButton: %>