Changeset 7a718e in indico

Timestamp:

06/08/10 11:33:35 (3 years ago)

Author:

Jose Benito <jose.benito.gonzalez@…>

Branches:

master, burotel, hello-world-walkthrough, ipv6, new-webex, v0.97-series, v0.98-series, v0.98.2, v0.98.3, v0.98b1, v0.98b2, v0.99, b8c30da8ebdbdcbd675a873997cc3e95f567de49, 4287315ec967a3da168d83963c14001db8487d53

Children:

6e2ea5

Parents:

9ea55a

git-author:

Pedro Ferreira <jose.pedro.ferreira@…> (06/01/10 11:37:25)

git-committer:

Jose Benito <jose.benito.gonzalez@…> (06/08/10 11:33:35)

Message:

[FIX] Vidyo: Auth manager - simplified code

• Clearer and simpler;

Location:

indico/MaKaC

Files:

• authentication/AuthenticationMgr.py (modified) (2 diffs)
• plugins/Collaboration/Vidyo/common.py (modified) (1 diff)

indico/MaKaC/authentication/AuthenticationMgr.py

@@ -78 +78 @@
         return None
 
-    def getAvatarByLogin(self, login, authenticator = None):
+    def getAvatarByLogin(self, login, auth = None):
         """ Returns an Avatar object based on the person's login.
-            If authenticator is set, we will only look in the given authenticator.
-            If not set, we will look in all autheticators.
+            If authList is set, we will only look in the given authenticators.
+            If not set, we will look in all authenticators.
             If we find this login in more than one authenticator, and there is at least 2
             different Avatar objects, we will return a dictionary authenticatorName:Avatar object.
@@ -89 +89 @@
             :type login: str
 
-            :param login: the name of an authenticator to use, or a list of authenticator names, or None
-            :type login: str, list or NoneType
+            :param auth: a list of names of the authenticators to use, or None
+            :type auth: str, list or NoneType
         """
 
-        if type(authenticator) is str:
-            #only one authenticator
-            auth = self.getById(authenticator)
+        if auth == None:
+            # search all authenticators
+            authList = self.AuthenticatorList
+        else:
+            # get the actual Authenticator objects
+            authList = list(self.getById(a) for a in auth)
+
+        # we search for Avatars in each authenticator
+        foundAvatars = {}
+        for auth in authList:
             try:
-                return auth.getAvatarByLogin(login)
+                avatar = auth.getAvatarByLogin(login)
+                foundAvatars[auth.getId().strip()] = avatar
             except KeyError:
-                return None
+                pass
 
-        else:
-            #multiple authenticators, we build a list of authenticators
-            if type(authenticator) is list:
-                authenticatorList = []
-                for authName in authenticator:
-                    authenticatorList.append(self.getById(authName))
-            else:
-                authenticatorList = self.AuthenticatorList
-
-            #we search for Avatars in each authenticator
-            foundAvatars = {}
-            avatarIdsFound = set()
-            for auth in authenticatorList:
-                try:
-                    avatar = auth.getAvatarByLogin(login)
-                    foundAvatars[auth.getId().strip()] = avatar
-                    avatarIdsFound.add(avatar.getId())
-                except KeyError:
-                    pass
-
-            if foundAvatars:
-                if len(foundAvatars) == 1 or len(avatarIdsFound) == 1:
-                    #there's only one different avatar
-                    return foundAvatars.values()[0]
-                else:
-                    #there's more than 1 avatar, we return a dictionary
-                    return foundAvatars
-            else:
-                #we found nothing, we return None
-                return None
-
+        return foundAvatars
 
     def isLoginFree( self, login):

indico/MaKaC/plugins/Collaboration/Vidyo/common.py

@@ -146 +146 @@
     @classmethod
     def getAvatarByAccountName(cls, accountName):
-        authenticatorsToUse = getVidyoOptionValue("authenticatorList")
-
-        foundAvatar = AuthenticatorMgr().getAvatarByLogin(accountName, authenticatorsToUse)
-        if foundAvatar:
-            if type(foundAvatar) is dict:
-                for authenticatorName in authenticatorsToUse:
-                    if authenticatorName in foundAvatar:
-                        foundAvatar = foundAvatar[authenticatorName]
-                        break
-            return foundAvatar
+        """
+        Retrieves the first avatar found using the authenticators in the
+        authenticatorList option (order is respected)
+        """
+        availableAuths = getVidyoOptionValue("authenticatorList")
+        foundAvatarDict = AuthenticatorMgr().getAvatarByLogin(accountName, availableAuths)
+
+        for authName in availableAuths:
+            foundAvatar = foundAvatarDict.get(authName, None)
+            if foundAvatar:
+                return foundAvatar
         else:
             return None