Changeset f17f3f in indico

Timestamp:

10/04/11 14:52:09 (20 months ago)

Author:

Jose Benito <jose.benito.gonzalez@…>

Branches:

master, hello-world-walkthrough, ipv6, v0.98-series, v0.98.2, v0.98.3, v0.98b2, v0.99, 051b2622c51afb171a1dedb46a0df4fbb0cbd02e, 0da0c1403bae8e51d8229f460181c71b9e6dda72

Children:

1a9ed6

Parents:

3bf46b

Message:

[IMP] Avoid commiting web sessions each request

Location:

indico

Files:

• MaKaC/webinterface/rh/base.py (modified) (2 diffs)
• MaKaC/webinterface/session/base.py (modified) (1 diff)
• MaKaC/webinterface/session/sessionManagement.py (modified) (4 diffs)
• htdocs/confModifSchedule.py (modified) (1 diff)

indico/MaKaC/webinterface/rh/base.py

@@ -248 +248 @@
                 sm.revoke_session_cookie( self._req )
                 self._websession = sm.get_session( self._req )
-            sm.maintain_session( self._req, self._websession )
 
     def _getSession( self ):
@@ -562 +561 @@
                                 res = self._process()
 
+                        # Save web session, just when needed
+                        sm = session.getSessionManager()
+                        sm.maintain_session( self._req, self._websession )
 
                         # notify components that the request has finished

indico/MaKaC/webinterface/session/base.py

@@ -409 +409 @@
             # had useful information and no longer does, we have to
             # explicitly forget it.
-            if self.has_session(session.id):
-                del self[session.id]
-                self.revoke_session_cookie(request)
+            #if self.has_session(session.id):
+            #    del self[session.id]
+            #    self.revoke_session_cookie(request)
             return
         if not self.has_session(session.id):

indico/MaKaC/webinterface/session/sessionManagement.py

@@ -46 +46 @@
         base.Session.__init__(self, request, id)
         self._lang = minfo.getLang()
-        self.setVar("ActiveTimezone","LOCAL")
+        self.datadict["ActiveTimezone"] = "LOCAL"
+
+    def has_info (self):
+        """has_info() -> boolean
+
+        Return true if this session contains any information that must
+        be saved.
+        """
+        # This flag will indicate when to commit a session
+        return getattr(self, '_v_modified', False)
 
     def setUser( self, newUser ):
@@ -52 +61 @@
             self._lang = newUser.getLang()
         self.user = newUser
-        #get_transaction().commit()
+        self._v_modified = True
 
     def getUser( self ):
@@ -66 +75 @@
             self.datadict = PersistentMapping()
             self.datadict[key] = value
+        self._v_modified = True
 
     def getVar(self, key):
@@ -85 +95 @@
         if self.datadict.has_key(key):
             del self.datadict[key]
+            self._v_modified = True
 
     def getLang(self):

indico/htdocs/confModifSchedule.py

@@ -25 +25 @@
 def index( req, **params ):
     return conferenceModif.RHConfModifSchedule( req ).process( params )
-
-def graphic( req, **params ):
-    return conferenceModif.RHConfModifScheduleGraphic( req ).process( params )
 
 def entries( req, **params ):